fix(a11y): add accessibility for dropdown submenu via tab #2508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2507
If a DropdownMenu contains a submenu, it currently opens on hover when the user moves the mouse over the item that triggers the submenu. However, the submenu is not accessible from the keyboard because it has no keyboard event handlers to open it.
As a result, this makes the submenu inaccessible for screen reader users — the submenu simply cannot be reached without a mouse.
I propose adding the necessary event handlers so that the submenu can also be opened via click (which works with Enter on the focused element and through standard screen reader interaction patterns).