Conversation
|
Preview is ready. |
|
🎭 Component Tests Report is ready. |
ca4d0eb to
869d946
Compare
313deb2 to
190b2ee
Compare
There was a problem hiding this comment.
I guess input should have clear button?
c4dbafd to
81f826b
Compare
| import {Flex} from '../layout'; | ||
|
|
||
| export type SuggestProps<T> = TextInputProps & { | ||
| items?: ListItemData<T>[]; |
There was a problem hiding this comment.
I would expect Suggest being almost identical to Select in almost every aspect except for the trigger (which is TextInput in this case) and the lack of filter in Popup
So the property should be called options and other props should be copied as is as well (with some exceptions)
I would expect the same visuals and behaviors as well
@amje what do you think?
There's also an inline mode in common's Suggest. Do you plan do add it as well?
There was a problem hiding this comment.
@Ruminat Which props do you want to copy? I agree with the naming of items
There was a problem hiding this comment.
@korvin89 These, I guess:
// at least these props, I guess
Pick<SelectProps,
| "onUpdate"
| "renderOption"
| "renderOptionGroup"
| "renderEmptyOptions"
| "renderPopup"
| "renderCounter"
| "getOptionHeight"
| "getOptionGroupHeight"
| "value"
| "defaultValue"
| "options"
| "error"
| "errorMessage"
| "errorPlacement"
| "validationState"
| "multiple"
| "filter"
| "onFilterChange"
| "disablePortal"
| "loading"
| "onLoadMore"
| "id"
| "hasCounter"
| "renderCounter"
| "disabled"
>
// Would like to see these ones as well
type NiceToHaveProps = {
readonly?: boolean;
inline?: boolean;
};eba7320 to
6e9ebd7
Compare
eaae402 to
79cba7f
Compare
No description provided.