gpld-conditional-limits.php: Fixed issue where GP Limit Dates' frontend assets were not being enqueued when using snippet.
#1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not working issue.
saifsultanc
approved these changes
Jan 23, 2025
Contributor
saifsultanc
left a comment
saifsultanc
left a comment
There was a problem hiding this comment.
Looks good to me!
@claygriffiths to have 1 final look 👀
spivurno
reviewed
Jan 23, 2025
|
claygriffiths
changed the title
gpld-conditional-limits.php: Fixed conditional limit dates snippet not working issue.gpld-conditional-limits.php: Fixed issue where GP Limit Dates' frontend assets were not being enqueued when using snippet.
claygriffiths
approved these changes
Jan 23, 2025
Contributor
claygriffiths
left a comment
claygriffiths
left a comment
There was a problem hiding this comment.
LGTM! S&M with the following:
`gpld-conditional-limits.php`: Fixed issue where GP Limit Dates' frontend assets were not being enqueued when using snippet.
When you S&M and a commit name/message/note is provided, put it into Commit header and clear out Commit message like so:
After:
saifsultanc
deleted the
malay/fix/76665-conditional-limit-dates-snippet-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2819363473/76665
Summary
This snippet works only if the
Minimum DateorMaximum Datefield is set in the GP Limit Dates perk.The issue arises when neither date is set, as the
gp-limit-datesJavaScript is not enqueued, causing it to not function.To resolve this, add the following filter to ensure the JavaScript is enqueued for the form and field.