gw-merge-tag-modifier-remove-spaces.php: Added new snippet.
#1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new PHP snippet has been introduced to add a custom merge tag modifier called Changes
Sequence Diagram(s)sequenceDiagram
participant GravityForms
participant MergeTagModifier
GravityForms->>MergeTagModifier: Process merge tag with modifier
alt Modifier is "remove_spaces" and value is not blank
MergeTagModifier->>MergeTagModifier: Remove all spaces from value
MergeTagModifier-->>GravityForms: Return modified value
else Modifier is not "remove_spaces" or value is blank
MergeTagModifier-->>GravityForms: Return original value
end
Possibly related PRs
Suggested reviewers
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
gravity-forms/gw-merge-tag-modifier-remove-spaces.php (1)
12-18: LGTM! Implementation is correct and clear.The snippet correctly implements the
remove_spacesmodifier for Gravity Forms merge tags. The logic is sound, and the code is concise and readable.Optionally, for broader applicability, consider supporting removal of all whitespace (tabs, newlines, etc.) using a regular expression:
- return str_replace( ' ', '', $value ); + return preg_replace( '/\s+/', '', $value );If you intend to only remove space characters, the current implementation is perfect. If you want to clarify this, you could add a note in the docblock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2909059270/82229?viewId=14960
Summary
Adds a merge tag modifier to remove spaces from a value.