Skip to content

gpld-populate-new-minimum-date-into-linked-date-field.js: Fixed an issue with default value of field not getting used to apply minimum date. #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2025
Merged

gpld-populate-new-minimum-date-into-linked-date-field.js: Fixed an issue with default value of field not getting used to apply minimum date. #1099

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f8a375
`gpld-populate-new-minimum-date-into-linked-date-field.js`: Fixed an …
saifsultanc May 8, 2025
59cc849
`gpld-populate-new-minimum-date-into-linked-date-field.js`: Fixed an …
saifsultanc May 9, 2025
d44d244
`gpld-populate-new-minimum-date-into-linked-date-field.js`: Fixed an …
saifsultanc May 9, 2025
1440cb6
`gpld-populate-new-minimum-date-into-linked-date-field.js`: Fixed an …
saifsultanc May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions gp-limit-dates/gpld-populate-new-minimum-date-into-linked-date-field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,17 @@
* 1. Install this snippet with our free Custom JavaScript plugin.
* https://gravitywiz.com/gravity-forms-code-chest/
*/
gform.addAction( 'gpld_after_set_min_date', function( $input, date ) {
$input.datepicker( 'setDate', date );
const sourceFieldId = 25; // Replace with the ID of the source field (Field A)
document.addEventListener( 'gform/post_render', ( event ) => {
const $field = jQuery( `#input_GFFORMID_${sourceFieldId}` );
const value = $field.val();
if ( value ) {
requestAnimationFrame( function(){
$field.trigger( 'input' ).trigger( 'change' );
});
}
Copy link

@coderabbitai coderabbitai bot May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add error handling for field selection

The code assumes the field will always be found, but this may not be true if the field ID is incorrect or the field is conditionally hidden. Consider adding error handling.

	const $field = jQuery( `#input_GFFORMID_${sourceFieldId}` );
+	if ($field.length === 0) {
+		console.error(`Source field with ID ${sourceFieldId} not found. Please check the field ID.`);
+		return;
+	}
	const value  = $field.val();
	if ( value ) {
		requestAnimationFrame( function(){
			$field.trigger( 'input' ).trigger( 'change' );
		});
	}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const value = $field.val();
if ( value ) {
requestAnimationFrame( function(){
$field.trigger( 'input' ).trigger( 'change' );
});
}
const $field = jQuery( `#input_GFFORMID_${sourceFieldId}` );
if ($field.length === 0) {
console.error(`Source field with ID ${sourceFieldId} not found. Please check the field ID.`);
return;
}
const value = $field.val();
if ( value ) {
requestAnimationFrame( function(){
$field.trigger( 'input' ).trigger( 'change' );
});
}

});

gform.addAction( 'gpld_after_set_min_date', function( $input, date ) {
$input.datepicker( 'setDate', date );
} );
Loading