gw-coupons-exclude-products.php: Fixed an issue with discount not applied correctly in some scenarios.

[saifsultanc]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2922744588/82764

Summary

The snippet above is affecting the product total during submission if the coupon type is flat rate.

Fixed the edge case conditional.

[coderabbitai]

Walkthrough

The conditional logic within the modify_coupon_discount_amount method was updated to refine how coupon discounts are adjusted when certain products are excluded. The new logic only overrides the discount with the excluded total if it is less than the current discount, adding a safeguard to prevent unnecessary overwriting.

Changes

File	Change Summary
gravity-forms/gw-coupons-exclude-products.php	Refined conditional logic in modify_coupon_discount_amount to only set discount to excluded total if smaller.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CouponSystem

    User->>CouponSystem: Apply coupon to cart
    CouponSystem->>CouponSystem: Check coupon type and amount
    alt Percentage type and not 100% and skipping enabled
        CouponSystem->>CouponSystem: Reduce discount by excluded price portion
    else Excluded total < current discount
        CouponSystem->>CouponSystem: Set discount to excluded total
    else
        CouponSystem->>CouponSystem: Leave discount unchanged
    end
    CouponSystem-->>User: Return final discount amount

Loading

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a602d7d and b4b086e.

📒 Files selected for processing (1)

• gravity-forms/gw-coupons-exclude-products.php (1 hunks)

🔇 Additional comments (1)

gravity-forms/gw-coupons-exclude-products.php (1)

196-198: Excellent fix for the coupon discount issue!

This change resolves the reported problem where flat rate coupon discounts were incorrectly applied. Previously, the discount was unconditionally set to the excluded total amount, which could result in a reduced discount even when it shouldn't be. With this conditional check, the discount is only set to the excluded total if it's less than the current discount, ensuring proper discount application in all scenarios.

The fix appropriately protects against overwriting a larger discount with a smaller excluded total, which is exactly what was needed to address the issue reported in the ticket.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against b4b086e