Skip to content

Conversation

@saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2943198385/83618

Summary

https://gravitywiz.com/snippet-library/gw-capitilize-submitted-data/

The snippet above is causing a fatal error if the form is submitted with a conditionally hidden List field.

PHP Fatal error:  Uncaught TypeError: array_map(): Argument #2 ($array) must be of type array, null given in ...

Loom (Samuel):
https://www.loom.com/share/f13287a7c9b84a8d9950bc2878fbf567

@coderabbitai
Copy link

coderabbitai bot commented May 27, 2025

Walkthrough

A conditional check was added to the data capitalization process to skip empty or unset submitted values in the Gravity Forms processing script. This ensures that empty or hidden fields are not processed for capitalization, while the rest of the logic remains unchanged.

Changes

File Change Summary
gravity-forms/gw-capitilize-submitted-data.php Added a check to skip capitalization for empty or unset submitted data

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GravityFormsScript

    User->>GravityFormsScript: Submit form data (POST)
    GravityFormsScript->>GravityFormsScript: For each input key
    alt Value is empty or not set
        GravityFormsScript-->>GravityFormsScript: Skip capitalization
    else Value present
        GravityFormsScript->>GravityFormsScript: Capitalize value
    end
    GravityFormsScript-->>User: Continue processing form
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0797abf and 10f3023.

📒 Files selected for processing (1)
  • gravity-forms/gw-capitilize-submitted-data.php (1 hunks)
🔇 Additional comments (1)
gravity-forms/gw-capitilize-submitted-data.php (1)

31-34: Excellent fix for the hidden list field fatal error!

This conditional check directly addresses the root cause described in the PR objectives. When a List field is conditionally hidden, $_POST[$input_key] becomes null, which would cause the array_map() function on line 37 to throw a fatal TypeError. By checking empty() and using continue, the code properly skips processing these hidden/empty fields and prevents the fatal error.

The placement is perfect - it occurs after the input key is set up but before the type-specific processing, ensuring hidden fields are handled gracefully.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 10f3023

@saifsultanc saifsultanc merged commit 505c724 into master May 30, 2025
3 of 4 checks passed
@saifsultanc saifsultanc deleted the saif/fix/83618-fix-hidden-list branch May 30, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants