gw-require-unique-values.php: Added support for whole-field validation for multi-input fields.

[SebastianWiz]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/3019475786/87093?viewId=8172236

Summary

Original issue/feature request: https://www.loom.com/share/7efd82e759514e21866854c87a802f2a (By Matt A.)

This adds support for allowing multi-input fields to be validated as a single, combined value.

Quick loom showing new feature: https://www.loom.com/share/22a0b59a9b6f46c69f708621f78d507b

[coderabbitai]

Walkthrough

The plugin's version was incremented from 0.2 to 0.3. The validation logic for multi-input fields was updated to allow treating the entire field as a single combined value for uniqueness checks, rather than validating each input separately. The logic in both the validate and get_filtered_value methods was modified to support this behavior.

Changes

Cohort / File(s)	Change Summary
Gravity Forms Unique Value Validation Update gravity-forms/gw-require-unique-values.php	Added private method get_all_field_ids() to combine configured and master field IDs; updated validation logic to treat multi-input fields as a single combined value when applicable; bumped plugin version from 0.2 to 0.3.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Form
    participant Plugin

    User->>Form: Submit form with multi-input field
    Form->>Plugin: Trigger validate()
    Plugin->>Plugin: Check if field ID is in combined field IDs
    alt Combined validation
        Plugin->>Plugin: Concatenate all subfield values into single string
        Plugin->>Plugin: Validate combined value for uniqueness
    else Per-input validation
        Plugin->>Plugin: Validate each input separately for uniqueness
    end
    Plugin-->>Form: Return validation result
    Form-->>User: Display success or error

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• gpeb-multi-field-sorting.php: Added snippet for multi field sorting on Entry Blocks. #1107: Introduces a class for multi-field sorting in Gravity Perks Entry Blocks, related to handling multi-input or multi-field scenarios similar to the updated validation logic in this PR.

Suggested reviewers

• veryspry

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f507348 and 961fa3a.

📒 Files selected for processing (1)

• gravity-forms/gw-require-unique-values.php (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• gravity-forms/gw-require-unique-values.php

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch seb/add/87093-multi-input-field-whole-validation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

	Fails
🚫	Commit message 'gw-require-unique-values.php: Added support for whole-field validation for multi-input fields' needs to end in a period or exclamation.

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 961fa3a

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8eef25a and f507348.

📒 Files selected for processing (1)

• gravity-forms/gw-require-unique-values.php (3 hunks)

🔇 Additional comments (2)

gravity-forms/gw-require-unique-values.php (2)

14-14: LGTM! Version increment is appropriate.

The version bump from 0.2 to 0.3 correctly reflects the addition of new functionality for whole-field validation of multi-input fields.

---

86-91: Field ID logic verified — no changes required
The array_merge of $this->_args['field_ids'] with master_field_id and subsequent in_array checks match existing patterns in gravity-forms/gw-require-unique-values.php. This whole‐field validation update is consistent with the rest of the class.