Skip to content

gpnf-sortable-entries.php: Fixed an issue where duplicated entries appeared in sortable child entries. #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

gpnf-sortable-entries.php: Fixed an issue where duplicated entries appeared in sortable child entries. #1165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion gp-nested-forms/gpnf-sortable-entries.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,16 @@ public function add_init_script_args( $args, $field, $form ) {
// Sort $args['entries'] which contains Gravity Forms entries arrays. They contain an 'id' key.
// $cookie_entries contains the entry IDs in the order they should be displayed.
$sorted_entries = array();
$valid_entry_ids = array();

foreach ( $cookie_entries as $entry_id ) {
$entry_id_str = (string) $entry_id;

foreach ( $args['entries'] as $entry ) {
if ( $entry['id'] == $entry_id ) {
// Use strict comparison and prevent duplicates
if ( (string) $entry['id'] === $entry_id_str && ! in_array( $entry_id_str, $valid_entry_ids, true ) ) {
$sorted_entries[] = $entry;
$valid_entry_ids[] = $entry_id_str;
break;
}
}
Expand Down