Skip to content

gw-limit-multiselect.js: Fixed an issue with limit multi-select not working with GP Advanced Select. #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gw-limit-multiselect.js: Fixed an issue with limit multi-select not working with GP Advanced Select. #687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions gravity-forms/gw-limit-multiselect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ function limitMultiSelect( $select, max ) {
.find( 'option:not(:checked)' )
.prop( 'disabled', selectedCount >= max )
.trigger( 'chosen:updated' );

// For Tom Select (GP Advanced Select)
// Update "1" to the ID of your Multi Select field.
if ( $( '#input_GFFORMID_1-ts-dropdown' ) ) {
$( '#input_GFFORMID_1-ts-dropdown .option' ).removeAttr( 'data-selectable' );
}
Comment on lines 63 to +71
Copy link
Contributor

@claygriffiths claygriffiths Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, if you unselect choices (to get below the max), do the disabled choices get re-enabled?

This snippet reads like even without Tom Select, they'd stay disabled.

Copy link
Contributor Author

@saifsultanc saifsultanc Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://secure.helpscout.net/conversation/2301130622/52247/#thread-6885586156

}
}

Expand Down