Skip to content

gw-disable-submit-button-until-required-fields-are-filled-out.php: Fixed a compatibility issue with GP Populate Anything. #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

gw-disable-submit-button-until-required-fields-are-filled-out.php: Fixed a compatibility issue with GP Populate Anything. #910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions gravity-forms/gw-disable-submit-button-until-required-fields-are-filled-out.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,15 @@ public function maybe_output_script( $form ) {
}

if ( ! self::$script_output ) {
$this->script();
add_action( 'wp_footer', array( $this, 'output_script' ) );
add_action( 'gform_preview_footer', array( $this, 'output_script' ) );
Comment on lines +35 to +36
Copy link
Contributor

@claygriffiths claygriffiths Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this to prevent AJAX errors?

Could we use gform_print_scripts instead?

Copy link
Contributor Author

@saifsultanc saifsultanc Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and I will check gform_print_scripts

Copy link
Contributor Author

@saifsultanc saifsultanc Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt work with gform_print_scripts, i think its because it not firing at the correct time.

Copy link
Contributor

@claygriffiths claygriffiths Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me considering this is a snippet. Thanks for checking!

self::$script_output = true;
}

return $form;
}

public function script() {
public function output_script() {
?>

<script type="text/javascript">
Expand Down Expand Up @@ -83,6 +84,15 @@ public function script() {
self.runCheck();
});

// Check when fields are repopulated because of GPPA
$(document).on( 'gppa_updated_batch_fields', function() {
self.runCheck();
});
// GPPA logic may enable submit button, disable that logic.
gform.addFilter( 'gppa_disable_form_navigation_toggling', function() {
return true;
});

self.runCheck();

}
Expand Down
Loading