gpuid-fill-sequence-gaps.php: Fixed an issue with the snippet not working.
#948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claygriffiths
approved these changes
Dec 13, 2024
Contributor
claygriffiths
left a comment
claygriffiths
left a comment
There was a problem hiding this comment.
One quick suggestion regarding how to get the table name.
Otherwise, LGTM. This will increase the minimum version requirement to 2.3, but I think we can all agree that's fine for a snippet 😃
When ready, S&M with:
`gpuid-fill-sequence-gaps.php`: Updated to use database schema in Gravity Forms 2.3 and newer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2790631747/75478
Summary
The snippet does not seem to work, it hasn't been update in over 2 years. The DB we are accessing is
wp_rg_lead_detail, but it seems GF 2.3+ it's expected that thewp_gf_entry_metashould be used instead. GF codebase for context: https://github.com/gravityforms/gravityforms/blob/master/export.php#L892-L910So we just apply the DB update, and that fixes the issue.
Here is how it works after the update:
https://www.loom.com/share/1819b282338d4832a68ce985787b16bb