Increase portability of tmpfs implementation to support BSDs#348
Open
morgant wants to merge 7 commits intograysky2:masterfrom
Open
Increase portability of tmpfs implementation to support BSDs#348morgant wants to merge 7 commits intograysky2:masterfrom
morgant wants to merge 7 commits intograysky2:masterfrom
Conversation
…th '-exec basename' since we just want the filename. Issue graysky2#344
…d use of non-portable --no-target-directory. Issue graysky2#344
Owner
|
Not sure how I feel about this since I do not have any BSD boxes/VMs for testing... have you been running the modified code on BSD? |
Contributor
Author
|
I have been running the modified code, but only under OpenBSD. I'd certainly prefer others running different BSDs and Linux distros confirm that this work there too. To be honest, I wasn't sure what you'd think either and am not in a rush to have these changes merged. I mainly wanted to put the idea out there, with some suggested changes, as food for thought. Edit: I'm happy to try to keep this PR updated as I maintain my OpenBSD port (though it hasn't been accepted into ports tree yet as there wasn't enough initial interest.) |
Owner
|
OK, let's keep this open as you said. Thank for your work to bring it to other users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Issue #344, this increases portability to BSDs (tmpfs implementation only, of course). Specifically, the following are addressed:
bashrminstead of non-portableunlinkfind's-printfcp's--reflink=automv's--no-target-directorypgrep's-cmodinfoif using OverlayFSThese changes have been extracted from my own patches for an OpenBSD port (https://github.com/morgant/my-openbsd-ports/blob/main/www/profile-sync-daemon/patches/patch-common_profile-sync-daemon_in). As noted in Issue #344, there are some additional options that differ across implementations of
du&stat, but I have left those changes out as there may still be some differences between BSDs that would be best applied as OS-specific patches. Similarly, OpenBSD'srsyncport doesn't support the-Xoption since the file system doesn't support metadata, so that should remain as an OpenBSD-specific patch.