Skip to content

modbus-debug #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

modbus-debug #771

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db4837a
modbus-debug
Jul 2, 2025
3b7db51
debug_printf
Jul 5, 2025
f290c1a
Merge branch 'grblHAL:master' into modbus-debug
andywwright Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion modbus_rtu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

*/


#include <stdio.h>
#include <string.h>

Expand Down Expand Up @@ -109,6 +110,21 @@ static bool valid_crc (const char *buf, uint_fast16_t len)
}
*/

#if DEBUG
static void log_modbus_frame(const char *label,
const uint8_t *data,
uint8_t len)
{
char frame[3 * MODBUS_MAX_ADU_SIZE + 4];
char *ptr = frame;
ptr += sprintf(ptr, "%s:", label);
for(uint_fast8_t i = 0; i < len; i++) {
ptr += sprintf(ptr, " %02X", data[i]);
}
debug_printf("%s", frame);
}
#endif

static void retry_exception (uint8_t code, void *context)
{
if(packet && packet->callbacks.retries) {
Expand Down Expand Up @@ -149,6 +165,9 @@ static void tx_message (volatile queue_entry_t *msg)
rx_timeout = modbus.rx_timeout;

stream.flush_rx_buffer();
#if DEBUG
log_modbus_frame("TX", (const uint8_t *)msg->msg.adu, msg->msg.tx_length);
#endif
stream.write((char *)((queue_entry_t *)msg)->msg.adu, ((queue_entry_t *)msg)->msg.tx_length);
}

Expand Down Expand Up @@ -240,6 +259,9 @@ static void modbus_poll (void *data)
}
}

#if DEBUG
log_modbus_frame("RX", (const uint8_t *)((queue_entry_t *)packet)->msg.adu, rx_len);
#endif
if((state = packet->async ? ModBus_Silent : ModBus_GotReply) == ModBus_Silent) {
if(packet->callbacks.on_rx_packet) {
packet->msg.rx_length = rx_len;
Expand Down Expand Up @@ -636,4 +658,4 @@ void modbus_rtu_init (int8_t stream, int8_t dir_aux)
task_run_on_startup(report_warning, "Modbus failed to initialize!");
system_raise_alarm(Alarm_SelftestFailed);
}
}
}