Conversation
auberonedu
reviewed
Feb 18, 2025
| String[] words = input.split("\\s+"); | ||
|
|
||
| for (String word : words) { | ||
| if (word.endsWith(".")) { |
| public List<String> tokenize(Scanner scanner) { | ||
| List<String> tokens = new ArrayList<>(); | ||
|
|
||
| String input = scanner.nextLine().toLowerCase(); |
There was a problem hiding this comment.
I think this only reads in a single line of input and doesn't handle multi-line input.
Comment on lines
+23
to
+30
| @Test | ||
| void testTokenizeWithExtraSpaces() { | ||
| LowercaseSentenceTokenizer tokenizer = new LowercaseSentenceTokenizer(); | ||
| Scanner scanner = new Scanner("hello hi hi hi hello hello"); | ||
| List<String> tokens = tokenizer.tokenize(scanner); | ||
|
|
||
| assertEquals(List.of("hello", "hi", "hi", "hi", "hello", "hello"), tokens); | ||
| } |
Comment on lines
+45
to
+56
| for (int i = 0; i < trainingWords.size() - 1; i++) { | ||
| String currentWord = trainingWords.get(i); | ||
| String nextWord = trainingWords.get(i + 1); | ||
|
|
||
| // this code mean ...if currentWord is not already in neighborMap, add it with an empty list as its value. | ||
|
|
||
|
|
||
| neighborMap.putIfAbsent(currentWord, new ArrayList<>()); | ||
|
|
||
| // Store the word that follows | ||
| neighborMap.get(currentWord).add(nextWord); | ||
| } |
Comment on lines
+117
to
+125
| String lastWord = context.get(context.size() - 1); // Get last word | ||
|
|
||
| if (neighborMap.containsKey(lastWord)) { | ||
| List<String> nextWords = neighborMap.get(lastWord); | ||
|
|
||
| if (!nextWords.isEmpty()) { | ||
| return nextWords.get(random.nextInt(nextWords.size())); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.