Open
Conversation
auberonedu
reviewed
Feb 18, 2025
auberonedu
left a comment
auberonedu
left a comment
There was a problem hiding this comment.
Nice job on the initial tokenization! However, it looks like the later waves aren't quite finished.
| public List<String> tokenize(Scanner scanner) { | ||
| // TODO: Implement this function to convert the scanner's input to a list of words and periods | ||
| return null; | ||
| ArrayList<String> tokenizedList = new ArrayList<>(); |
There was a problem hiding this comment.
Remember to use interface types where appropriate (List)
Comment on lines
+37
to
+40
| while (scanner.hasNext()) { | ||
| String item = scanner.next(); | ||
| tokenizedList.add(item); | ||
| } |
There was a problem hiding this comment.
This works well for spaces, but doesn't quite handle the periods
Comment on lines
+22
to
+29
| @Test | ||
| void testNoSpaceToken() { | ||
| LowercaseSentenceTokenizer tokenizer = new LowercaseSentenceTokenizer(); | ||
| Scanner scanner = new Scanner("hello hi hi hi hello hello"); | ||
| List<String> tokens = tokenizer.tokenize(scanner); | ||
|
|
||
| assertEquals(List.of("hello", "hi", "hi", "hi", "hello", "hello"), tokens); | ||
| } |
Comment on lines
+52
to
+62
| public List<String> train(Scanner scanner) { | ||
| List<String> trainingWords = tokenizer.tokenize(scanner); | ||
|
|
||
|
|
||
| // TODO: Convert the trainingWords into neighborMap here | ||
| while (scanner.hasNext()) { | ||
| String train = scanner.next(); | ||
| trainingWords.add(train); | ||
| } | ||
|
|
||
| return trainingWords; |
There was a problem hiding this comment.
This doesn't quite implement the logic we're hoping for - we were looking to fill the neighborMap here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.