fix(hid): correct bSize encoding for HID short items #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the HID short item generator where the size field (bSize) was derived directly from the number of data bytes. According to the HID specification, the size bits do not represent the literal number of bytes, but instead use a 2-bit code:
The previous implementation incorrectly used len(octets) as the value for these bits, resulting in malformed descriptors (for example, a 4-byte item still produced bSize = 0).
Small example: