-
Notifications
You must be signed in to change notification settings - Fork 105
Add a global JSON index file inside Multi-language Rules Specification archive #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the code suggestion, it'll be very useful in case I can't put my idea of a stand-alone tool into practice. I'd love not to have to throw away my work done in #303.
First I need to update the JSON format and the website mock-up with your feedback on the possibilities for structuring the rules.
0737e5a to
a1a2129
Compare
You can see needed updates on website in this commit : jycr/green-code-initiative-website@7ee4316 |
bc7ab8c to
5252b46
Compare
50f64d8 to
5a2d8aa
Compare
| echo "::set-output name=ref_name::${{ github.ref_name }}" | ||
| echo "::set-output name=commit_sha::${{ github.sha }}" | ||
| deploy-to-gh-pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also use the "GitHub action" approach to reduce complexity in this workflow. Check the official doc here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all transparency, I'm completely new to GitHub Actions.
My proposal is therefore very much open to improvement.
Please feel free to suggest concrete improvements by adding commits directly to this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't the build folder name be perceived by contributors as a folder with generated files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. What name would you suggest? As far as I know, there is no convention for naming the directory that should contain resources used only by the build process itself.
065959d to
d7924da
Compare
609bd5f to
f60b72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let @utarwyn do the review because he knows very well this part of system.
f60b72b to
169a45e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following our discussion, I propose to keep only the JShell migration in this PR. The generation of the rules JSON file will be dealt with in #303
|
This PR has been automatically marked as stale because it has no activity for 60 days. |


Updates dependencies and adds a
index.jsonfile into the global (all languages) JAR file.This index file contains:
By default,
mainbranch and tags are published to GitHub Pages:https://green-code-initiative.github.io/creedengo-rules-specifications/
Closes #301