Skip to content

Conversation

@jycr
Copy link
Contributor

@jycr jycr commented Apr 24, 2025

Updates dependencies and adds a index.json file into the global (all languages) JAR file.

This index file contains:

  • rule metadata by rule key for each language
  • in the metadata of each rule:
    • adds the path to the HTML description file
    • extracts the terms from the HTML description (this will facilitate text searches)

By default, main branch and tags are published to GitHub Pages:
https://green-code-initiative.github.io/creedengo-rules-specifications/

Closes #301

@jycr jycr requested review from dedece35 and utarwyn April 24, 2025 21:49
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code suggestion, it'll be very useful in case I can't put my idea of a stand-alone tool into practice. I'd love not to have to throw away my work done in #303.

First I need to update the JSON format and the website mock-up with your feedback on the possibilities for structuring the rules.

@jycr jycr force-pushed the feature/add-index-json-file branch from 0737e5a to a1a2129 Compare April 24, 2025 23:30
@jycr
Copy link
Contributor Author

jycr commented Apr 25, 2025

First I need to update the JSON format and the website mock-up with your feedback on the possibilities for structuring the rules.

You can see needed updates on website in this commit : jycr/green-code-initiative-website@7ee4316

@jycr jycr requested a review from utarwyn April 28, 2025 14:48
@jycr jycr changed the title Feature/add index json file Add a global JSON index file inside Multi-language Rules Specification archive May 2, 2025
@jycr jycr force-pushed the feature/add-index-json-file branch 2 times, most recently from bc7ab8c to 5252b46 Compare May 2, 2025 15:48
@jycr jycr force-pushed the feature/add-index-json-file branch 4 times, most recently from 50f64d8 to 5a2d8aa Compare May 4, 2025 00:10
echo "::set-output name=ref_name::${{ github.ref_name }}"
echo "::set-output name=commit_sha::${{ github.sha }}"
deploy-to-gh-pages:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also use the "GitHub action" approach to reduce complexity in this workflow. Check the official doc here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all transparency, I'm completely new to GitHub Actions.

My proposal is therefore very much open to improvement.

Please feel free to suggest concrete improvements by adding commits directly to this branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the build folder name be perceived by contributors as a folder with generated files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. What name would you suggest? As far as I know, there is no convention for naming the directory that should contain resources used only by the build process itself.

@jycr jycr force-pushed the feature/add-index-json-file branch from 065959d to d7924da Compare May 6, 2025 00:34
@jycr jycr requested a review from utarwyn May 6, 2025 00:38
@jycr jycr force-pushed the feature/add-index-json-file branch 3 times, most recently from 609bd5f to f60b72b Compare May 6, 2025 00:54
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let @utarwyn do the review because he knows very well this part of system.

@jycr jycr force-pushed the feature/add-index-json-file branch from f60b72b to 169a45e Compare May 19, 2025 15:02
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following our discussion, I propose to keep only the JShell migration in this PR. The generation of the rules JSON file will be dealt with in #303

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rules export tool for consultation website

4 participants