Skip to content

GCI3 [Team LESS][2025] - Add Js rule #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GCI3 [Team LESS][2025] - Add Js rule #403

wants to merge 1 commit into from

Conversation

@safaaoug
Copy link

@safaaoug safaaoug commented May 20, 2025 •
edited
Loading

Add new JS rule GCI3

@safaaoug safaaoug changed the title feat: add Js rule GCI3 Add Js rule GCI3 (LESS) May 21, 2025
utarwyn
utarwyn requested changes May 21, 2025
View reviewed changes
@mathis-girault mathis-girault mentioned this pull request May 21, 2025
Closed
@MP-Aubay MP-Aubay changed the title Add Js rule GCI3 (LESS) GCI3 [Team LESS][2025] - Add Js rule May 21, 2025
MP-Aubay
MP-Aubay requested changes May 21, 2025
View reviewed changes
CHANGELOG.md

- Correction of various typos in rules documentations

### Changed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the Changed title above, the "Correction of various typos..." was in Changed section

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 21, 2025
utarwyn
utarwyn reviewed Jul 29, 2025
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋
Did you have any reference or blog article which validates the rule? I have made some tests using https://jsperf.app and the results are quite the same with both compliant/non-compliant solutions. This awesome v8 blog article (Chromium engine) also talks about loops and it kind of challenges the existance of this rule.

So I think we should discuss the relevance of the rule before integrating it into the rule specification repository.

@github-actions github-actions bot removed the stale label Jul 30, 2025
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utarwyn utarwyn utarwyn requested changes

@MP-Aubay MP-Aubay MP-Aubay requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

stale 👀 👀 waiting commiter 👀 👀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@safaaoug @MP-Aubay @utarwyn