Rename groovy SupportedVersionRangeRule to EC5002 for rule key homogeneisation

Author: jhertout

android-plugin/src/main/resources/org/sonar/plugins/groovy/cost.csv

@@ -1,4 +1,4 @@
 ruleKey;remediationFunction;remediationFactor
 EC5001;linear;1h
-org.codenarc.rule.ecocode.SupportedVersionRangeRule;linear;10min
+EC5002;linear;10min
 org.codenarc.rule.ecocode.DisableObfuscationRule;linear;10min

android-plugin/src/main/resources/org/sonar/plugins/groovy/profile-default.txt

@@ -1,3 +1,3 @@
 EC5001
-org.codenarc.rule.ecocode.SupportedVersionRangeRule
+EC5002
 org.codenarc.rule.ecocode.DisableObfuscationRule

android-plugin/src/main/resources/org/sonar/plugins/groovy/rules.xml

@@ -46,10 +46,10 @@
 
   <!-- since 2.2.1 -->
   <rule>
-    <key>org.codenarc.rule.ecocode.SupportedVersionRangeRule</key>
+    <key>EC5002</key>
     <severity>MINOR</severity>
     <name><![CDATA[Supported Version Range]]></name>
-    <internalKey><![CDATA[SupportedVersionRange]]></internalKey>
+    <internalKey><![CDATA[EC5002]]></internalKey>
     <description><![CDATA[<p>When looking at the minSdkVersion and targetSdkVersion (or minSdk, targetSdk) attributes for the <uses-sdk> in the AndroidManifest.xml file, the amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.</p>
 <p>Example of violations:</p>
 <pre><code>android {

codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRules.groovy.txt

@@ -89,6 +89,7 @@ ruleset {
     DuplicateSetValue 
     DuplicateStringLiteral 
     EC5001
+    EC5002
     ElseBlockBraces 
     EmptyCatchBlock 
     EmptyClass
@@ -304,7 +305,6 @@ ruleset {
     StaticMatcherField 
     StaticMethodsBeforeInstanceMethods 
     StaticSimpleDateFormatField
-    SupportedVersionRange
     SwallowThreadDeath 
     SynchronizedMethod 
     SynchronizedOnBoxedPrimitive 

codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRulesByCategory.groovy.txt

@@ -167,7 +167,7 @@ ruleset {
 
     // rulesets/ecocode.xml
     EC5001
-    SupportedVersionRange
+    EC5002
     DisableObfuscation
 
     // rulesets/enhanced.xml

codenarc-converter/CodeNarc/docs/codenarc-rule-index-by-name.md

@@ -91,6 +91,7 @@ title: CodeNarc - Rule Index by Name
 * [DuplicateSetValue](./codenarc-rules-basic.html#duplicatesetvalue-rule)
 * [DuplicateStringLiteral](./codenarc-rules-dry.html#duplicatestringliteral-rule)
 * [EC5001](./codenarc-rules-ecocode.html#EC5001-rule)
+* [EC5002](./codenarc-rules-ecocode.html#EC5002-rule)
 * [ElseBlockBraces](./codenarc-rules-braces.html#elseblockbraces-rule)
 * [EmptyCatchBlock](./codenarc-rules-basic.html#emptycatchblock-rule)
 * [EmptyClass](./codenarc-rules-basic.html#emptyclass-rule)
@@ -306,7 +307,6 @@ title: CodeNarc - Rule Index by Name
 * [StaticMatcherField](./codenarc-rules-concurrency.html#staticmatcherfield-rule)
 * [StaticMethodsBeforeInstanceMethods](./codenarc-rules-convention.html#staticmethodsbeforeinstancemethods-rule)
 * [StaticSimpleDateFormatField](./codenarc-rules-concurrency.html#staticsimpledateformatfield-rule)
-* [SupportedVersionRange](./codenarc-rules-ecocode.html#supportedversionrange-rule)
 * [SwallowThreadDeath](./codenarc-rules-exceptions.html#swallowthreaddeath-rule)
 * [SynchronizedMethod](./codenarc-rules-concurrency.html#synchronizedmethod-rule)
 * [SynchronizedOnBoxedPrimitive](./codenarc-rules-concurrency.html#synchronizedonboxedprimitive-rule)

codenarc-converter/CodeNarc/docs/codenarc-rule-index.md

@@ -168,7 +168,7 @@ title: CodeNarc - Rule Index
 
 ## [Ecocode](./codenarc-rules-ecocode.html)
 * [EC5001](./codenarc-rules-ecocode.html#EC5001-rule)
-* [SupportedVersionRange](./codenarc-rules-ecocode.html#supportedversionrange-rule)
+* [EC5002](./codenarc-rules-ecocode.html#EC5002-rule)
 * [DisableObfuscation](./codenarc-rules-ecocode.html#disableobfuscation-rule)
 
 ## [Enhanced](./codenarc-rules-enhanced.html)

codenarc-converter/CodeNarc/docs/codenarc-rules-ecocode.md

@@ -45,7 +45,7 @@ Example of violations:
     }
 ```
 
-## SupportedVersionRange Rule
+## EC5002 Rule
 
 *Since CodeNarc 2.2.1*
 

codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/SupportedVersionRangeRule.groovy renamed to codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5002.groovy

@@ -26,19 +26,19 @@ import org.codenarc.util.AstUtil
  *
  * @author Leboulanger Mickael
  */
-class SupportedVersionRangeRule extends AbstractAstVisitorRule {
+class EC5002 extends AbstractAstVisitorRule {
 
-    String name = 'SupportedVersionRange'
+    String name = 'EC5002'
     int priority = 2
     int minSdkVersion = 0
     int minSdk = 0
     int targetSdkVersion = 0
     int targetSdk = 0
     int threshold = 4 // Value used to compare minSdkVersion and targetSdkVersion
-    Class astVisitorClass = SupportedVersionRangeAstVisitor
+    Class astVisitorClass = EC5002AstVisitor
 }
 
-class SupportedVersionRangeAstVisitor extends AbstractAstVisitor {
+class EC5002AstVisitor extends AbstractAstVisitor {
 
     @Override
     void visitMethodCallExpression(MethodCallExpression methodCallExpression) {

codenarc-converter/CodeNarc/src/main/resources/codenarc-base-messages.properties

@@ -2,8 +2,8 @@
 DisableObfuscation.description=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
 DisableObfuscation.description.html=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
 
-SupportedVersionRange.description=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
-SupportedVersionRange.description.html=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
+EC5002.description=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
+EC5002.description.html=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
 
 EC5001.description=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
 EC5001.description.html=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.