Rename groovy DisableObfuscationRule to EC5002 for rule key homogeneisation

Author: jhertout

android-plugin/src/main/resources/org/sonar/plugins/groovy/cost.csv

@@ -1,4 +1,4 @@
 ruleKey;remediationFunction;remediationFactor
 EC5001;linear;1h
 EC5002;linear;10min
-org.codenarc.rule.ecocode.DisableObfuscationRule;linear;10min
+EC5003;linear;10min

android-plugin/src/main/resources/org/sonar/plugins/groovy/profile-default.txt

@@ -1,3 +1,3 @@
 EC5001
 EC5002
-org.codenarc.rule.ecocode.DisableObfuscationRule
+EC5003

android-plugin/src/main/resources/org/sonar/plugins/groovy/rules.xml

@@ -86,10 +86,10 @@
 
   <!-- since 2.2.3 -->
   <rule>
-    <key>org.codenarc.rule.ecocode.DisableObfuscationRule</key>
+    <key>EC5003</key>
     <severity>MINOR</severity>
     <name><![CDATA[Disable Obfuscation]]></name>
-    <internalKey><![CDATA[DisableObfuscation]]></internalKey>
+    <internalKey><![CDATA[EC5003]]></internalKey>
     <description><![CDATA[<p>Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.</p>
 <p>Example of violations:</p>
 <pre><code>    android {

codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRules.groovy.txt

@@ -77,7 +77,6 @@ ruleset {
     CyclomaticComplexity   // Requires the GMetrics jar
     DeadCode 
     DirectConnectionManagement
-    DisableObfuscation
     DoubleCheckedLocking 
     DoubleNegative 
     DuplicateCaseStatement 
@@ -90,6 +89,7 @@ ruleset {
     DuplicateStringLiteral 
     EC5001
     EC5002
+    EC5003
     ElseBlockBraces 
     EmptyCatchBlock 
     EmptyClass

codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRulesByCategory.groovy.txt

@@ -168,7 +168,7 @@ ruleset {
     // rulesets/ecocode.xml
     EC5001
     EC5002
-    DisableObfuscation
+    EC5003
 
     // rulesets/enhanced.xml
     CloneWithoutCloneable 

codenarc-converter/CodeNarc/docs/codenarc-rule-index-by-name.md

@@ -79,7 +79,6 @@ title: CodeNarc - Rule Index by Name
 * [CyclomaticComplexity](./codenarc-rules-size.html#cyclomaticcomplexity-rule)    (Requires the GMetrics jar)
 * [DeadCode](./codenarc-rules-basic.html#deadcode-rule)
 * [DirectConnectionManagement](./codenarc-rules-jdbc.html#directconnectionmanagement-rule)
-* [DisableObfuscation](./codenarc-rules-ecocode.html#disableobfuscation-rule)
 * [DoubleCheckedLocking](./codenarc-rules-concurrency.html#doublecheckedlocking-rule)
 * [DoubleNegative](./codenarc-rules-basic.html#doublenegative-rule)
 * [DuplicateCaseStatement](./codenarc-rules-basic.html#duplicatecasestatement-rule)
@@ -92,6 +91,7 @@ title: CodeNarc - Rule Index by Name
 * [DuplicateStringLiteral](./codenarc-rules-dry.html#duplicatestringliteral-rule)
 * [EC5001](./codenarc-rules-ecocode.html#EC5001-rule)
 * [EC5002](./codenarc-rules-ecocode.html#EC5002-rule)
+* [EC5003](./codenarc-rules-ecocode.html#EC5003-rule)
 * [ElseBlockBraces](./codenarc-rules-braces.html#elseblockbraces-rule)
 * [EmptyCatchBlock](./codenarc-rules-basic.html#emptycatchblock-rule)
 * [EmptyClass](./codenarc-rules-basic.html#emptyclass-rule)

codenarc-converter/CodeNarc/docs/codenarc-rule-index.md

@@ -169,7 +169,7 @@ title: CodeNarc - Rule Index
 ## [Ecocode](./codenarc-rules-ecocode.html)
 * [EC5001](./codenarc-rules-ecocode.html#EC5001-rule)
 * [EC5002](./codenarc-rules-ecocode.html#EC5002-rule)
-* [DisableObfuscation](./codenarc-rules-ecocode.html#disableobfuscation-rule)
+* [EC5003](./codenarc-rules-ecocode.html#EC5003-rule)
 
 ## [Enhanced](./codenarc-rules-enhanced.html)
 * [CloneWithoutCloneable](./codenarc-rules-enhanced.html#clonewithoutcloneable-rule)

codenarc-converter/CodeNarc/docs/codenarc-rules-ecocode.md

@@ -83,7 +83,7 @@ android {
 }
 ```
 
-## DisableObfuscation Rule
+## EC5003 Rule
 
 *Since CodeNarc 2.2.3*
 

codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/DisableObfuscationRule.groovy renamed to codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5003.groovy

@@ -27,14 +27,14 @@ import org.codenarc.util.AstUtil
  *
  * @author Berque Justin
  */
-class DisableObfuscationRule extends AbstractAstVisitorRule {
+class EC5003 extends AbstractAstVisitorRule {
 
-    String name = 'DisableObfuscation'
+    String name = 'EC5003'
     int priority = 2
-    Class astVisitorClass = DisableObfuscationAstVisitor
+    Class astVisitorClass = EC5003AstVisitor
 }
 
-class DisableObfuscationAstVisitor extends AbstractAstVisitor {
+class EC5003AstVisitor extends AbstractAstVisitor {
 
     @Override
     void visitMethodCallExpression(MethodCallExpression methodCallExpression) {

codenarc-converter/CodeNarc/src/main/resources/codenarc-base-messages.properties

@@ -1,6 +1,6 @@
 
-DisableObfuscation.description=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
-DisableObfuscation.description.html=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
+EC5003.description=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
+EC5003.description.html=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
 
 EC5002.description=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
 EC5002.description.html=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.