-
Notifications
You must be signed in to change notification settings - Fork 33
New metric boxes #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ribalba
wants to merge
7
commits into
main
Choose a base branch
from
new-metric-boxes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New metric boxes #1279
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
327bf39
Generate metric cards dynamically
ribalba 33f9c4a
Adds font files
ribalba a0d40e1
os swith
ribalba 8914163
First working example
ribalba 7c9f1ea
Review comments
ribalba 4795553
Merge branch 'main' into new-metric-boxes
ArneTR 1999954
renamed variable to reflext dimension [skip ci]
ArneTR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -60,6 +60,12 @@ const network_energy_metric_condition = (metric) => { | |||||||||
return false; | ||||||||||
} | ||||||||||
|
||||||||||
const network_io_metric_condition = (metric) => { | ||||||||||
if(metric == 'network_io_cgroup_container') return true; | ||||||||||
return false; | ||||||||||
} | ||||||||||
|
||||||||||
|
||||||||||
const machine_power_metric_condition = (metric) => { | ||||||||||
if(metric.match(/^.*_power_.*_machine$/) !== null) return true; | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. low: It's better to use a single return statement.
Suggested change
|
||||||||||
return false; | ||||||||||
|
@@ -246,6 +252,11 @@ METRIC_MAPPINGS = { | |||||||||
"source": "Formula", | ||||||||||
"explanation": "Estimated external energy cost for network infrastructure." | ||||||||||
}, | ||||||||||
"network_power_formula_global": { | ||||||||||
ribalba marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
"clean_name": "Network Transmission", | ||||||||||
"source": "Formula", | ||||||||||
"explanation": "Estimated external energy cost for network infrastructure." | ||||||||||
}, | ||||||||||
"network_carbon_formula_global": { | ||||||||||
"clean_name": "Network Transmission CO₂", | ||||||||||
"source": "Formula", | ||||||||||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.