Updated echarts to v.6.0 #1282
Merged
Updated echarts to v.6.0 #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 I did not experience any errors. Only changes I have seen are visual:
btw: because you have copied the description from the old PR, the description of this PR includes wrong statements. |
davidkopp
approved these changes
Aug 9, 2025
|
@davidkopp thanks for the description hint. Updated. @ribalba : Can you also give it a look |
|
works without errors on my Mac with Brave |
ArneTR
added a commit
that referenced
this pull request
Aug 12, 2025
* main: Bump actions/create-github-app-token in /.github/workflows (#1284) Bump pylint from 3.3.7 to 3.3.8 (#1285) Updated echarts vor v.6.0 (#1282) Bump python from 3.13.5-slim-bookworm to 3.13.6-slim-bookworm in /docker (#1286) Bump deepdiff from 8.5.0 to 8.6.0 (#1283) Log parsing on full data (#1276) Bump redis from 6.3.0 to 6.4.0 (#1281) Added Gemini PR Review measurement_flow_process_duration is set in any case. Supplying a timeout of None will lead to no timeout Detect systemd cgroup path using cgroup name (instead of container id) (#1270) Bump redis from 6.2.0 to 6.3.0 (#1275) Removing sampling_rate for XGboost also from codespaces lsmod now uses sort Added kernel modules to listing (fix): Warnings error should not show on HTTP 204 - case is expected Fix NetworkIoCgroupSystemProvider doesn't create a value column (#1274) Clarifying comment for design decision Document the usage of cgroup system metric providers (#1273) Suspend check (#1269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative PR to #1280
@ribalba
@davidkopp
an you please if you experience any errors with these charts?
We have no visual tests to verify and furthermore echarts does not throw errors when a feature is missing suprisingly. I used a custom variant of the package which is commented in the JS file at the top.
To inject demo data into a fresh install run python3 tools/import_data.py data/demo_data.sql
Note: echarts has breaking changes in v6 ... on GitHub it reads like we might not be too affected. Only a different legend might be problematical. Did not spot it thouth so far https://github.com/apache/echarts/releases/tag/6.0.0