remove file path syntax for imports#16
Open
austinkline wants to merge 2 commits intogreen-goo-dao:mainfrom
Open
remove file path syntax for imports#16austinkline wants to merge 2 commits intogreen-goo-dao:mainfrom
austinkline wants to merge 2 commits intogreen-goo-dao:mainfrom
Conversation
Contributor
|
How does this work with testing frameworks? When I tried this the last time i had to have an emulator running in project to get my editor to work. I dont like that. |
bjartek
reviewed
Apr 18, 2023
bjartek
reviewed
Apr 18, 2023
bjartek
reviewed
Apr 18, 2023
Contributor
bjartek
left a comment
bjartek
left a comment
There was a problem hiding this comment.
Not sure if the tools are ready for this yet. Can see if i have time to get overflow to play with it
Co-authored-by: Bjarte S. Karlsen <bjarte@bjartek.org>
Contributor
Author
|
Sure enough, we need flow-js-testing to support this so it's blocked for now, we can circle back once that's been resolved |
bjartek
approved these changes
Dec 15, 2023
Contributor
|
Looks like this has already been done now, with the switch to the Cadence testing framework? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the file path imports since new versions of the flow cli don't need it. If we do this, you can use submodules to pull in standard repos so you don't have to copy other contracts anymore!