Skip to content

fix(react-hook-form): update Controller component type definition #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mununki merged 2 commits into from
Mar 18, 2025
+13 −12
Merged

fix(react-hook-form): update Controller component type definition #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3260235
fix(react-hook-form): update Controller component type definition
mununki Mar 18, 2025
859166f
change log
mununki Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# v0.0.8 (unrelease)

- Add `useWatch` hook
- Updated Controller component type definition in react-hook-form: made name parameter required and rules parameter optional

# v0.0.7

Expand Down
4 changes: 2 additions & 2 deletions doc/transformation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ module ControllerOfInputs = {

@module("react-hook-form") @react.component
external make: (
~name: variantOfInputs=?,
~name: variantOfInputs,
~control: controlOfInputs=?,
~rules: controllerRulesOfInputs,
~rules: controllerRulesOfInputs=?,
~render: controllerFieldsOfInputs => React.element=?,
) => React.element = "Controller"
}
Expand Down
10 changes: 5 additions & 5 deletions src/ppx/signature.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,9 +539,9 @@ let map_type_decl
];
(* @module("react-hook-form") @react.component
external make: (
~name: variantOfInputs=?,
~name: variantOfInputs,
~control: controlOfInputs=?,
~rules: controllerRulesOfInputs,
~rules: controllerRulesOfInputs=?,
~render: controllerFieldsOfInputs => React.element=?,
) => React.element = "Controller" *)
Sig.value
Expand All @@ -564,17 +564,17 @@ let map_type_decl
(Typ.constr ~attrs:[ attr_named_arg ]
(lid @@ "variantOf" ^ capitalize record_name)
[])
(Typ.arrow (Labelled "control")
(Typ.arrow (Optional "control")
(Typ.constr ~attrs:[ attr_named_arg ]
(lid @@ "controlOf"
^ capitalize record_name)
[])
(Typ.arrow (Labelled "rules")
(Typ.arrow (Optional "rules")
(Typ.constr ~attrs:[ attr_named_arg ]
(lid @@ "controllerRulesOf"
^ capitalize record_name)
[])
(Typ.arrow (Labelled "render")
(Typ.arrow (Optional "render")
(uncurried_core_type_arrow
~attrs:[ attr_named_arg ] ~arity:1
[
Expand Down
10 changes: 5 additions & 5 deletions src/ppx/structure.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,9 +538,9 @@ let map_type_decl
];
(* @module("react-hook-form") @react.component
external make: (
~name: variantOfInputs=?,
~name: variantOfInputs,
~control: controlOfInputs=?,
~rules: controllerRulesOfInputs,
~rules: controllerRulesOfInputs=?,
~render: controllerFieldsOfInputs => React.element=?,
) => React.element = "Controller" *)
Str.primitive
Expand All @@ -563,17 +563,17 @@ let map_type_decl
(Typ.constr ~attrs:[ attr_named_arg ]
(lid @@ "variantOf" ^ capitalize record_name)
[])
(Typ.arrow (Labelled "control")
(Typ.arrow (Optional "control")
(Typ.constr ~attrs:[ attr_named_arg ]
(lid @@ "controlOf"
^ capitalize record_name)
[])
(Typ.arrow (Labelled "rules")
(Typ.arrow (Optional "rules")
(Typ.constr ~attrs:[ attr_named_arg ]
(lid @@ "controllerRulesOf"
^ capitalize record_name)
[])
(Typ.arrow (Labelled "render")
(Typ.arrow (Optional "render")
(uncurried_core_type_arrow
~attrs:[ attr_named_arg ] ~arity:1
[
Expand Down