fix: fix potential connection leaks on non-ok http status codes#110
Merged
fix: fix potential connection leaks on non-ok http status codes#110
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Conventional Commits Report
🚀 Conventional commits found. |
mgoetzegb
force-pushed
the
fix-connection-leak
branch
from
816f213 to
4f9e195
Compare
Modver resultThis report was generated by Modver, This PR does not require a change in your module’s version number. |
alex-heine
reviewed
Nov 24, 2025
alex-heine
approved these changes
Nov 28, 2025
Even the response of a non-ok http status code can contain a body. So we should close the body of a (on transport layer) sucessful request unconditionally. Otherwise we can leak a http connection.
mgoetzegb
force-pushed
the
fix-connection-leak
branch
from
fbbd002 to
4c30b72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fix: fix potential connection leaks on non-ok http status codes
Even the response of a non-ok http status code can contain a body. So we should close the body of a (on transport layer) sucessful request unconditionally. Otherwise we can leak a http connection.
Why
Don't leak connections.