Conversation
Conventional Commits Report
🚀 Conventional commits found. |
Member
Author
|
tests fail with go version |
Modver resultThis report was generated by Modver, This PR does not require a change in your module’s version number. |
f144706 to
10830a9
Compare
… for incorrect client cert
10830a9 to
517bf44
Compare
llugin
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Return invalid credentials errors on custom nginx error codes for incorrect client cert.
This improves the user feedback in some cases when supplying invalid client certificates.
However this covers only a subset of possible server behaviors on invalid client certificates, but those are the only cases which can be clearly attributed to invalid/missing client certs.
Some common server responses from CSAF Provider on invalid or missing client certificate:
Why
Better error feedback.
References
VTI-659