Skip to content

change: return invalid credentials errors on custom nginx error codes for incorrect client cert#96

Merged
mgoetzegb merged 1 commit intomain-gbfrom
improve-client-cert-errors
Oct 9, 2025
Merged

change: return invalid credentials errors on custom nginx error codes for incorrect client cert#96
mgoetzegb merged 1 commit intomain-gbfrom
improve-client-cert-errors

Conversation

@mgoetzegb
Copy link
Member

What

Return invalid credentials errors on custom nginx error codes for incorrect client cert.

This improves the user feedback in some cases when supplying invalid client certificates.

However this covers only a subset of possible server behaviors on invalid client certificates, but those are the only cases which can be clearly attributed to invalid/missing client certs.

Some common server responses from CSAF Provider on invalid or missing client certificate:

Why

Better error feedback.

References

VTI-659

@mgoetzegb mgoetzegb requested a review from a team as a code owner October 8, 2025 14:10
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@mgoetzegb mgoetzegb added the minor release Set label to create a minor release label Oct 8, 2025
@mgoetzegb
Copy link
Member Author

tests fail with go version 1.25.2, but pass with 1.25.0, failure is not related to this PR

@mgoetzegb mgoetzegb marked this pull request as draft October 8, 2025 14:25
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR does not require a change in your module’s version number.
(You might still consider bumping the patchlevel anyway.)

@mgoetzegb mgoetzegb force-pushed the improve-client-cert-errors branch from f144706 to 10830a9 Compare October 8, 2025 15:24
@mgoetzegb mgoetzegb force-pushed the improve-client-cert-errors branch from 10830a9 to 517bf44 Compare October 8, 2025 16:07
@mgoetzegb mgoetzegb marked this pull request as ready for review October 8, 2025 16:07
@mgoetzegb mgoetzegb enabled auto-merge (squash) October 8, 2025 16:08
@mgoetzegb mgoetzegb merged commit 0a60e46 into main-gb Oct 9, 2025
5 of 6 checks passed
@mgoetzegb mgoetzegb deleted the improve-client-cert-errors branch October 9, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor release Set label to create a minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants