docs: update redis-server to 8.2.2 #600
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
soumya-greenbone
temporarily deployed
to
github-pages
GitHub Actions
Inactive
bjoernricks
left a comment
bjoernricks
left a comment
There was a problem hiding this comment.
This change should not be required at all. We should provide our desired redis server image with the latest tag always. In this case the users will get the newest and best redis container image just with a docker compose pull. By using a version tag in the compose file the users would have to re-download the compose file over and over again just to get a new redis server image (for example redis server 8.2.3)
src/_static/docker-compose-22.4.yml
Outdated
|
|
||
| redis-server: | ||
| image: registry.community.greenbone.net/community/redis-server | ||
| image: registry.community.greenbone.net/community/redis-server:8.2.2 |
There was a problem hiding this comment.
but wouldn't we still use latest instead of hardcoded version?
soumya-greenbone
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
|
||
| redis-server: | ||
| image: registry.community.greenbone.net/community/redis-server | ||
| image: registry.community.greenbone.net/community/redis-server:latest |
There was a problem hiding this comment.
Not sure if you are ware of it. This is actually the same. if a image tag is missing, latest is used actually.
|
So Soumya the only thing you may want to document is, that we changed the base image from debian:stable to official redis:stable in order to resolve greenbone/greenbone-container-images#30 |
|
We don't need this changes and hence closing the PR |
What
Update redis-server image to version 8.2.2.
Why
Ensures users run the patched Redis release.
References
DOS-483
Checklist