Merged
Conversation
The files should not be copied into the context when building a new container image.
Don't add cert files to git accidentally.
bjoernricks
force-pushed
the
gvm-config-container
branch
3 times, most recently
from
a6821a4 to
30fd5a3
Compare
bjoernricks
force-pushed
the
gvm-config-container
branch
from
30fd5a3 to
447bb21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a new container for setting up nginx usable to serve our GVM stack
Why
Allow to serve all static content with a dedicated web server and forward API requests to the services implementing it. In future we want to be able to cut specific API calls from gsad/gvmd into a new or several new services.
References
https://jira.greenbone.net/browse/GEA-1565