Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Tehforsch
commented
Mar 17, 2026
Comment on lines
650
to
+655
| if let Some(nvt) = nvt.take() { | ||
| self.dispatch_nvt(nvt); | ||
| // TODO: This might very well not work. | ||
| // Do we really need this Drop impl anyways? | ||
| futures::executor::block_on(async { | ||
| self.dispatch_nvt(nvt).await; | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
This is a complicated issue, I would have liked to remove this drop impl but that requires rethinking the entire logic about setting the nvt fields in the ScanCtx (which arguably should be done in the ScriptCtx instead?) and it got too big for this already big PR. The current solution works, although it is ugly.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Tehforsch
force-pushed
the
async-storage
branch
from
f842034 to
feec75f
Compare
Revive all test code and downstream builtins afterwards.
Tehforsch
force-pushed
the
async-storage
branch
from
feec75f to
4b0075e
Compare
Tehforsch
force-pushed
the
async-storage
branch
from
4b0075e to
b25a2aa
Compare
jjnicola
approved these changes
Mar 20, 2026
Kraemii
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the massive PR, but this PR is basically the minimum set of changes that are demanded by putting async in front of retrieve, dispatch and remove.
To make my life easier, I removed all unnecessary trait bounds that we demanded of various types using the storage traits (
ContextStoragein particular), so I could keep the trait bounds that needed to be added to a minimum.Jira: SC-1511