Skip to content

Conversation

@bjoernricks
Copy link
Contributor

What

Update method names for handling requests

Why

Make the purpose of the methods more obvious.

@github-actions
Copy link

github-actions bot commented Jan 29, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA a9c10d2.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@github-actions
Copy link

github-actions bot commented Jan 29, 2025

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 97.45763% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.74%. Comparing base (8fd3d4e) to head (a9c10d2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
gvm/protocols/gmp/_gmp224.py 97.52% 5 Missing ⚠️
gvm/protocols/gmp/_gmp226.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1198   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          71       71           
  Lines        4967     4967           
  Branches      895      895           
=======================================
  Hits         4855     4855           
  Misses         76       76           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Make it more obvious that these methods are handling requests and
responses.
@bjoernricks bjoernricks marked this pull request as ready for review February 3, 2025 09:22
@bjoernricks bjoernricks requested a review from a team February 3, 2025 09:22
@bjoernricks bjoernricks enabled auto-merge (rebase) February 3, 2025 09:59
@bjoernricks bjoernricks merged commit e105de3 into main Feb 3, 2025
24 of 25 checks passed
@bjoernricks bjoernricks deleted the improve-gvm-protocol branch February 3, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants