Skip to content

Conversation

@janl
Copy link
Contributor

@janl janl commented May 23, 2018

No description provided.

@janl janl force-pushed the test/faster-docker-maybe branch from 2897ca4 to 2d443c5 Compare June 17, 2018 07:06
@janl
Copy link
Contributor Author

janl commented Jun 17, 2018

this re-adds package-lock.json again which reduces nom install time on travis from ~22s to ~10s. Which is a ~5% impact on total runtime.

We should discuss whether we want to add this.

If we do, I’d recommend we all install the npm-merge-driver, that helps with auto-resolving lock file conflicts.

@janl janl requested review from IrinaJay, Realtin and espy July 9, 2018 12:38
@janl
Copy link
Contributor Author

janl commented Jul 9, 2018

@espy @hulkoba @Realtin review pls <3

@rmehner
Copy link
Contributor

rmehner commented Jul 9, 2018

Random Drive By (I'm working on all my emails right now and this just popped up): If you use a current npm version and you do have a package-lock.json, then you might wanna use npm ci instead of npm install, which will speed up the install even more.

@janl
Copy link
Contributor Author

janl commented Jul 9, 2018

@rmehner thanks, yes! :)

This is a one-step-at-a-time thing where I want to bring back package-lock.json :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants