fix: use compact to remove empty strings from CIDR sets#125
Merged
grem11n merged 2 commits intogrem11n:masterfrom Jul 16, 2025
Merged
fix: use compact to remove empty strings from CIDR sets#125grem11n merged 2 commits intogrem11n:masterfrom
grem11n merged 2 commits intogrem11n:masterfrom
Conversation
grem11n
approved these changes
Jul 16, 2025
Contributor
Author
|
@grem11n is it possible to get a release with this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Terraform
compactfunction to the CIDR locals to remove any empty string or null values which can occur if a subnet within a VPC being peered does not have an IPv6 CIDR.I included this on the IPv4 CIDR lists as well to keep things the same.