Skip to content

attemptWithStyle didn't always wait for reporting to terminal to finish #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinheghan merged 1 commit into from
Jul 27, 2025
Merged

attemptWithStyle didn't always wait for reporting to terminal to finish #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion builder/src/Reporting.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,15 @@ attemptWithStyle style toReport work =
result <- work `catch` reportExceptionsNicely
case result of
Right a ->
return a
case style of
Silent ->
return a
Json ->
return a
Terminal mvar ->
do
readMVar mvar
return a
Left x ->
case style of
Silent ->
Expand Down