This repository was archived by the owner on Feb 18, 2026. It is now read-only.
[INTERNAL] RDS-1527: changing defaults so that model params and blueprints match#620
Open
andreatgretel wants to merge 1 commit intodevelopfrom
Open
[INTERNAL] RDS-1527: changing defaults so that model params and blueprints match#620andreatgretel wants to merge 1 commit intodevelopfrom
andreatgretel wants to merge 1 commit intodevelopfrom
Conversation
Contributor
andreatgretel
commented
Jun 3, 2025
- num_records is always 1000 in all task defaults; in param defaults, it is 5000 for TabFT/TabGAN and 10 for TextFT. Recommendation - set param defaults to 1000 in all cases (this might be slow for TextFT though!)
- for TextFT, steps is 750 for the task default; in param defaults, both steps and epochs are empty. I think this is fine - we need to be opinionated about some params in task default, but not necessarily in param defaults
- for TextFT, generate.maximum_text_length is 100 in task default and 42 in param default. Also, train.max_tokens is 512 in param default (and empty in task default). Recommendation - set all of these to 128. This is still relatively short, but at least wouldn't affect runtime too much.
- for TabGAN, there's a mismatch in almost all parameters: generator_dim and discriminator_dim are 1024x1024 in task and 256x256 in param; generator_lr and discriminator_lr are 2e-4/2e-4 in task and 1e-4, 3.3e-4 in param; epochs is auto in task and 600 in param; batch_size is auto in task and 500 in param. Recommendation - make params all equal to task.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexahaushalter
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.