Skip to content

Conversation

@softmarshmallow
Copy link
Member

@softmarshmallow softmarshmallow commented Jan 26, 2026

Summary by CodeRabbit

  • Chores

    • CI workflows broadened to detect changes in nested directories, improving trigger coverage.
    • Bumped canary package version, removed an obsolete prebuild patch script, and simplified packaging notes to keep Emscripten glue separate.
    • Updated WebAssembly linker flags for exception/longjmp handling.
    • Updated EMSDK version and its submodule pointer.
  • Refactor

    • Native platform initialization internals reworked with no user-facing behavior changes.
  • Note

    • No changes to public APIs or user-facing behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 26, 2026 4:19pm
grida Ready Ready Preview, Comment Jan 26, 2026 4:19pm
5 Skipped Deployments
Project Deployment Review Updated (UTC)
code Ignored Ignored Jan 26, 2026 4:19pm
legacy Ignored Ignored Jan 26, 2026 4:19pm
backgrounds Skipped Skipped Jan 26, 2026 4:19pm
blog Skipped Skipped Jan 26, 2026 4:19pm
viewer Skipped Skipped Jan 26, 2026 4:19pm

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Warning

Rate limit exceeded

@softmarshmallow has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

Expanded workflow pull_request globs to recursive patterns; bumped wasm package version and removed its prebuild patch; switched native backend init to use AnySurfaceState; added Emscripten linker rustflags for wasm; removed two unused serde default helpers; updated emsdk version and submodule pointer.

Changes

Cohort / File(s) Summary
Workflow Path Filters
\.github/workflows/build-canvas.yml, \.github/workflows/test-crates.yml
Changed pull_request path filters from single-level globs (.github/workflows/*, crates/*) to recursive globs (.github/workflows/**, crates/**).
WASM Package & Docs
crates/grida-canvas-wasm/package.json, crates/grida-canvas-wasm/AGENTS.md
Bumped package version (0.90.0-canary.00.90.0-canary.2); updated AGENTS.md to stop instructing patching and to externalize Emscripten glue.
Removed Prebuild Patch Script
crates/grida-canvas-wasm/scripts/prebuild-patch-emscripten-js-glue.cjs
Deleted script that patched Emscripten JS glue to rewrite Node built-in requires.
WASM Cargo Config
crates/grida-canvas-wasm/.cargo/config.toml
Added wasm32-unknown-emscripten rustflags: -C link-arg=-fexceptions and -C link-arg=-sSUPPORT_LONGJMP=1 (with explanatory comments).
Native Backend Init
crates/grida-dev/src/platform/native_application.rs
Replaced direct Backend usage with AnySurfaceState wrapper; obtain backend via state.backend() after AnySurfaceState::from_gpu(state).
IO Defaults Removal
crates/grida-canvas/src/io/io_grida.rs
Removed unused helper functions default_locked() -> bool and default_z_index() -> i32.
EMSDK Version & Submodule
bin/activate-emsdk, third_party/externals/emsdk
Updated EMSDK_VERSION from 4.0.7 to 5.0.0; advanced emsdk submodule pointer to new commit.

Sequence Diagram(s)

(omitted — changes do not introduce a new multi-component sequential flow requiring visualization)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

cg

Poem

🐇 I nibbled globs and hopped the tree,

Canary climbed to two for me,
I wrapped the surface, found the backend,
Removed a patch and tweaked the link,
Tiny rabbit fixes, light and free.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'emsdk 5.0.0' accurately reflects the main change—updating Emscripten SDK to version 5.0.0 across configuration files, submodule pointers, and related dependencies.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch canary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel vercel bot temporarily deployed to Preview – blog January 26, 2026 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – viewer January 26, 2026 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – backgrounds January 26, 2026 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – blog January 26, 2026 16:14 Inactive
@vercel vercel bot temporarily deployed to Preview – viewer January 26, 2026 16:14 Inactive
@vercel vercel bot temporarily deployed to Preview – backgrounds January 26, 2026 16:14 Inactive
@softmarshmallow softmarshmallow merged commit 3e7235a into main Jan 26, 2026
11 of 12 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant