-
Notifications
You must be signed in to change notification settings - Fork 0
Support for FESpaces and Facet integration on Triangulations covering a subdomain of that of the Octree model #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amartinhuertas
wants to merge
30
commits into
main
Choose a base branch
from
fe_space_on_triangulation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of non-conforming octree models WIP: debugging
Split such code base into easier-to-read re-usable functions
* Debugged the case on which a regular face may have hanging faces on its boundary (w.r.t. setting proper interior_boundary ids)
mesh for which I am not able to recover the solution in the FE space. I am not sure if there is something fundamental here that I might be missing, but I am pretty sure there is no BUG (99%)
- Additional bug-fixes related to handling of hanging faces on ghost cells - Misc tidying tasks - Designed a test that circumvents #76
to GridapEmbedded.jl
DG SIP formulation on a portion of a non-conforming, octree mesh
structures on non-conforming meshes. Compared to the previous algorithm, we can choose facets individually to be part of the SkeletonTriangulation, including the possibility to have only one of the subfaces in the interface of two cells at different refinement levels
It can be reproduced with the following command: mpirun -np 4 julia --project=. test/mpi/PoissonNonConformingOctreeModelsTests.jl
Removed Manifest.toml (no longer required, as the required Gridap changes were released in 0.19.6)
Member
Author
|
tests are passing now |
non-conforming octree mesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP ... do not merge yet