Skip to content

display composites as label#1057

Merged
Mathieu-Deharbe merged 4 commits intomainfrom
composites-labeling
Mar 26, 2026
Merged

display composites as label#1057
Mathieu-Deharbe merged 4 commits intomainfrom
composites-labeling

Conversation

@Mathieu-Deharbe
Copy link
Copy Markdown
Contributor

display composites as label

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe Mathieu-Deharbe self-assigned this Mar 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b45f1ec6-c6e5-45fe-b9b1-f3ef3208d110

📥 Commits

Reviewing files that changed from the base of the PR and between a1bad06 and a3ab9ba.

📒 Files selected for processing (3)
  • src/hooks/useModificationLabelComputer.tsx
  • src/translations/en/networkModificationsEn.ts
  • src/translations/fr/networkModificationsFr.ts

📝 Walkthrough

Walkthrough

This pull request adds support for composite modifications by extending the label computation logic to handle the new modification type and providing English and French translation entries for UI display.

Changes

Cohort / File(s) Summary
Label Computation Logic
src/hooks/useModificationLabelComputer.tsx
Adds handling for COMPOSITE_MODIFICATION type in the label computation switch statement to return modificationMetadata.name instead of the default fallback value.
Translation Files
src/translations/en/networkModificationsEn.ts, src/translations/fr/networkModificationsFr.ts
Adds new translation entries for network_modifications.COMPOSITE_MODIFICATION mapping to the template string '{computedLabel}' in both English and French.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'display composites as label' accurately reflects the main change: adding support for displaying composite modifications with their label as the computed label.
Description check ✅ Passed The description 'display composites as label' is directly related to the changeset, describing the primary functionality being added for composite modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@Mathieu-Deharbe Mathieu-Deharbe merged commit f5f2820 into main Mar 26, 2026
6 checks passed
@Mathieu-Deharbe Mathieu-Deharbe deleted the composites-labeling branch March 26, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants