Skip to content

Check styles and export augmentation mui #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Check styles and export augmentation mui #582

wants to merge 9 commits into from

Conversation

Tristan-WorkGH
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH commented Sep 18, 2024 •
edited
Loading

  • Styles definitions more stricts
    • now in const assertions
    • styles are checked against Mui Theme rules
  • Mui Theme enriched with aggrid custom rules missing
    • exported custom mui rules for simpler re-use in fronts apps
    • update readme for how-to
    • doesn't need vite plugin, npm can do it itself during pack
  • AgGrid theme is refactored to better integrate with MUI

@Tristan-WorkGH Tristan-WorkGH self-assigned this Sep 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@capyq capyq capyq approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@Tristan-WorkGH Tristan-WorkGH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tristan-WorkGH @capyq