Skip to content

Fix NaN in previous value #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Fix NaN in previous value #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/inputs/reactHookForm/utils/HelperPreviousValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ export function HelperPreviousValue({

// this is not a real TS check as (previousValue === undefined)
// but prevent some bypassed TS checks from a parent which possibly sends null
if ((!previousValue && previousValue !== 0) || Number.isNaN(previousValue)) {
if (
(!previousValue && previousValue !== 0) ||
Number.isNaN(previousValue) ||
previousValue === 'NaN' /* TODO to remove when network-map-server never return string 'NaN' */
) {
return undefined;
}

Expand Down
Loading