First implementation for gridsuite-computation lib #1

ghazwarhili · 2025-07-15T14:53:48Z

No description provided.

thangqp · 2025-07-17T08:22:55Z

README.md

+[![Coverage Status](https://sonarcloud.io/api/project_badges/measure?project=org.gridsuite%computation&metric=coverage)](https://sonarcloud.io/component_measures?id=org.gridsuite%computation&metric=coverage)
+[![MPL-2.0 License](https://img.shields.io/badge/license-MPL_2.0-blue.svg)](https://www.mozilla.org/en-US/MPL/2.0/)
+
+Shared library for common computation and filter classes.


Suggested change

Shared library for common computation and filter classes.

Common library for computation and result filtering.

or just Library for computation and result filtering ( I mean without Common ) ?

but it is okey for Common
done

thangqp · 2025-07-17T08:25:45Z

pom.xml

+
+    <packaging>jar</packaging>
+    <name>Computation library</name>
+    <description>A shared library for common computation and filter classes</description>


Suggested change

<description>A shared library for common computation and filter classes</description>

<description>Common library for computation and result filtering.</description>

thangqp · 2025-07-17T09:03:56Z

pom.xml

+        <spring-boot.version>3.3.3</spring-boot.version>
+        <spring-cloud.version>2023.0.1</spring-cloud.version>
+
+        <powsybl-dependencies.version>2025.0.2</powsybl-dependencies.version>
+        <powsybl-network-store-client.version>1.27.2</powsybl-network-store-client.version>
+
+        <lombok.version>1.18.34</lombok.version>
+        <org-apache-commons.version>4.4</org-apache-commons.version>
+        <org.hamcrest.version>2.2</org.hamcrest.version>
+
+        <gridsuite-filter.version>1.4.0</gridsuite-filter.version>
+
+        <sonar.organization>gridsuite</sonar.organization>
+        <sonar.projectKey>org.gridsuite:computation</sonar.projectKey>


Suggested change

<spring-boot.version>3.3.3</spring-boot.version>

<spring-cloud.version>2023.0.1</spring-cloud.version>

<powsybl-dependencies.version>2025.0.2</powsybl-dependencies.version>

<powsybl-network-store-client.version>1.27.2</powsybl-network-store-client.version>

<lombok.version>1.18.34</lombok.version>

<org-apache-commons.version>4.4</org-apache-commons.version>

<org.hamcrest.version>2.2</org.hamcrest.version>

<gridsuite-filter.version>1.4.0</gridsuite-filter.version>

<sonar.organization>gridsuite</sonar.organization>

<sonar.projectKey>org.gridsuite:computation</sonar.projectKey>

<powsybl-ws-dependencies.version>2.22.0</powsybl-ws-dependencies.version>

<powsybl-network-store.version>1.28.0</powsybl-network-store.version>

<gridsuite-filter.version>1.5.0</gridsuite-filter.version>

<spring-boot.version>3.3.3</spring-boot.version>

<spring-cloud.version>2023.0.1</spring-cloud.version>

<lombok.version>1.18.34</lombok.version>

<org-apache-commons.version>4.4</org-apache-commons.version>

<org.hamcrest.version>2.2</org.hamcrest.version>

<sonar.organization>gridsuite</sonar.organization>

<sonar.projectKey>org.gridsuite:computation</sonar.projectKey>

<powsybl-network-store-client.version>1.28.0</powsybl-network-store-client.version> and not <powsybl-network-store.version>1.28.0</powsybl-network-store.version>

In my opinion, powsybl-network-store-client always matches the powsybl-network-store.version. Therefore, when overriding the client, it's more appropriate to use powsybl-network-store.version

However, it should include a TODO: To be removed comment for the next powsybl-ws-dependencies migration.

powsybl-network-store-client always matches the powsybl-network-store.version

EtienneLt · 2025-07-17T09:28:17Z

have you checked sonar issues ?

ghazwarhili · 2025-07-17T09:44:59Z

@EtienneLt #1 (comment)
This is out of scope for this PR because I didn’t modify the code (it is about moving code), and the sonar errors come from code that isn’t mine. I’m also intentionally not changing the moved code to keep traceability, but I can still fix the errors.
@etiennehomer what do you think ?

etiennehomer · 2025-07-18T07:59:25Z

@EtienneLt #1 (comment) This is out of scope for this PR because I didn’t modify the code (it is about moving code), and the sonar errors come from code that isn’t mine. I’m also intentionally not changing the moved code to keep traceability, but I can still fix the errors. @etiennehomer what do you think ?

As it is minor changes, it is ok to fix them in this PR. But it's also a good thing to keep the code the same when we move a lot of code as you do here. So up to you

thangqp · 2025-07-18T08:10:42Z

pom.xml

+        <dependency>
+            <groupId>com.powsybl</groupId>
+            <artifactId>powsybl-network-store-client</artifactId>
+            <version>${powsybl-network-store-client.version}</version>


Suggested change

<version>${powsybl-network-store-client.version}</version>

we do not need version except override but we use ${powsybl-network-store}

ghazwarhili · 2025-07-18T11:37:08Z

#1 (comment)
sonar issues fixed in 13ab75e

thangqp · 2025-07-18T14:29:22Z

pom.xml

+        <powsybl-ws-dependencies.version>2.22.0</powsybl-ws-dependencies.version>
+        <gridsuite-filter.version>1.5.0</gridsuite-filter.version>


Suggested change

<powsybl-ws-dependencies.version>2.22.0</powsybl-ws-dependencies.version>

<gridsuite-filter.version>1.5.0</gridsuite-filter.version>

<powsybl-ws-dependencies.version>2.23.0</powsybl-ws-dependencies.version>

<gridsuite-filter.version>1.6.0</gridsuite-filter.version>

sonarqubecloud · 2025-07-18T14:47:10Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ghazwarhili added 2 commits July 15, 2025 16:53

First implementation for gridsuite-computation lib

4a1c7dc

add dependencies version

7e946ce

ghazwarhili self-assigned this Jul 16, 2025

ghazwarhili added 3 commits July 16, 2025 14:58

some fix

c30dd59

CI fix

55a7807

sonar failure

52b65be

gridsuite deleted a comment from github-advanced-security bot Jul 17, 2025

fix README.md

b47e501

thangqp reviewed Jul 17, 2025

View reviewed changes

ghazwarhili requested a review from thangqp July 17, 2025 09:37

code review Thang

ddc6b37

thangqp reviewed Jul 18, 2025

View reviewed changes

clean pom file

0ede4d1

ghazwarhili requested a review from thangqp July 18, 2025 11:13

fix sonar issues

13ab75e

ghazwarhili requested a review from EtienneLt July 18, 2025 11:35

thangqp reviewed Jul 18, 2025

View reviewed changes

thangqp self-requested a review July 18, 2025 14:29

thangqp approved these changes Jul 18, 2025

View reviewed changes

EtienneLt approved these changes Jul 18, 2025

View reviewed changes

update dependencies version

e2dc317

ghazwarhili merged commit 258b6b2 into main Jul 18, 2025
4 checks passed

	Shared library for common computation and filter classes.
	Common library for computation and result filtering.

	<description>A shared library for common computation and filter classes</description>
	<description>Common library for computation and result filtering.</description>

		<powsybl-ws-dependencies.version>2.22.0</powsybl-ws-dependencies.version>
		<gridsuite-filter.version>1.5.0</gridsuite-filter.version>

First implementation for gridsuite-computation lib #1

First implementation for gridsuite-computation lib #1

Uh oh!

Conversation

ghazwarhili commented Jul 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EtienneLt commented Jul 17, 2025

Uh oh!

ghazwarhili commented Jul 17, 2025

Uh oh!

etiennehomer commented Jul 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghazwarhili commented Jul 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 18, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!