[Dynamic Margin Calculation] Base configuration #1
Conversation
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
|
| DynamicMarginCalculationResultRepository resultRepository; | ||
|
|
||
| @Autowired | ||
| DynamicMarginCalculationResultService dynamicSecurityAnalysisResultService; |
There was a problem hiding this comment.
| DynamicMarginCalculationResultService dynamicSecurityAnalysisResultService; | |
| DynamicMarginCalculationResultService dynamicMarginCalculationResultService; |
| private static final Logger LOGGER = LoggerFactory.getLogger(RestResponseEntityExceptionHandler.class); | ||
|
|
||
| @ExceptionHandler(DynamicMarginCalculationException.class) | ||
| protected ResponseEntity<Object> handleDynamicSecurityAnalysisException(DynamicMarginCalculationException exception) { |
There was a problem hiding this comment.
| protected ResponseEntity<Object> handleDynamicSecurityAnalysisException(DynamicMarginCalculationException exception) { | |
| protected ResponseEntity<Object> handleDynamicMarginCalculationException(DynamicMarginCalculationException exception) { |
| } | ||
|
|
||
| @Test | ||
| void testCrud() { |
There was a problem hiding this comment.
It's heavy to add all those tests for an "empty" server. You could make it simpler before you really code into your DMC server
There was a problem hiding this comment.
In my opinion, the result service is useful for verifying whether Spring Framework configurations (such as JPA and database settings) are functioning correctly.
Additionally, it helps reduce the amount of code in the next ticket, which will focus more on functional aspects.
No description provided.