Refactor nominal voltage filter to support voltage ranges #101
+22
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced nominal voltage field with voltage ranges in `GlobalFilter`. Updated related methods, rules, and tests to handle range-based filtering using `BETWEEN` operator. Signed-off-by: Florent MILLOT <[email protected]> Signed-off-by: Florent MILLOT <[email protected]>
EtienneLt
reviewed
Jan 7, 2026
src/main/java/org/gridsuite/filter/globalfilter/GlobalFilterUtils.java
Outdated
Show resolved
Hide resolved
Mathieu-Deharbe
approved these changes
Jan 8, 2026
Contributor
Mathieu-Deharbe
left a comment
Mathieu-Deharbe
left a comment
There was a problem hiding this comment.
OK (given that the specific OperatorType.BETWEEN with open ended end will be done in an other PR)
…ils.java Co-authored-by: Mathieu Deharbe <[email protected]>
EtienneLt
approved these changes
Jan 9, 2026
Contributor
EtienneLt
left a comment
EtienneLt
left a comment
There was a problem hiding this comment.
Code OK Test OK
in another issue to fix the min max
# Conflicts: # src/main/java/org/gridsuite/filter/globalfilter/GlobalFilterUtils.java # src/test/java/org/gridsuite/filter/globalfilter/GlobalFilterUtilsTest.java
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Replaced the
nominal voltagefield inGlobalFilterbyvoltage ranges. Updated methods, rules, and tests to enable filtering based on ranges using theBETWEENoperator.