Fix filtering on tabs that have several equipment types #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: basseche <[email protected]>
Signed-off-by: basseche <[email protected]>
basseche
force-pushed
the
Fix_GlobalFilters
branch
from
3432bb2 to
1405c9b
Compare
Mathieu-Deharbe
approved these changes
Dec 11, 2025
Contributor
Mathieu-Deharbe
left a comment
Mathieu-Deharbe
left a comment
There was a problem hiding this comment.
Code OK, test OK. Only some remarks on the comments.
src/main/java/org/gridsuite/filter/globalfilter/GlobalFilterUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/globalfilter/GlobalFilterUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/globalfilter/GlobalFilterUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/globalfilter/GlobalFilterUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: basseche <[email protected]>
…ils.java Co-authored-by: Mathieu Deharbe <[email protected]>
…ils.java Co-authored-by: Mathieu Deharbe <[email protected]>
Signed-off-by: basseche <[email protected]>
Signed-off-by: basseche <[email protected]>
Signed-off-by: basseche <[email protected]>
basseche
force-pushed
the
Fix_GlobalFilters
branch
from
071c7c6 to
e82e99b
Compare
* cache information for generic filters Signed-off-by: basseche <[email protected]>
Signed-off-by: basseche <[email protected]>
…alFilters # Conflicts: # src/main/java/org/gridsuite/filter/globalfilter/GlobalFilterUtils.java # src/test/java/org/gridsuite/filter/globalfilter/GlobalFilterUtilsTest.java
--------- Signed-off-by: Thang PHAM <[email protected]>
|
thangqp
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When filtering on a list that contains several equipment types, if we have generic filters with equipment types different than Substation/ Voltage level, it excludes other types if they does not also have generic filters.
For example if we filter on a list with transformers and lines, and i add generic filters on lines, and another filter(not generic), only lines are shown. Also if i add substation or voltage level generic filters to the previous filters, only lines are shown.