Skip to content

Check styles declaration against MUI Theme with TypeScript #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2025
Merged

Check styles declaration against MUI Theme with TypeScript #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
766252e
Check styles with TypeScript
Tristan-WorkGH Sep 11, 2025
73fecd8
Update commons-ui
Tristan-WorkGH Sep 12, 2025
2b8649b
Merge remote-tracking branch 'origin/main' into fix-mui-theme
Tristan-WorkGH Sep 15, 2025
378ccd3
Merge remote-tracking branch 'origin/main' into fix-mui-theme
Tristan-WorkGH Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/App/PageNotFound.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/

import Container from '@mui/material/Container';
import { Container } from '@mui/material';
import ErrorOutlineIcon from '@mui/icons-material/ErrorOutline';
import { ReactNode } from 'react';
import { type MuiStyles } from '@gridsuite/commons-ui';

const styles = {
error: {
Expand All @@ -18,7 +19,7 @@ const styles = {
container: {
marginTop: '70px',
},
};
} as const as MuiStyles;

const PageNotFound = ({ message }: { message: ReactNode }) => {
return (
Expand Down
4 changes: 2 additions & 2 deletions src/components/Grid/AgGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
useRef,
} from 'react';
import { AgGridReact } from 'ag-grid-react';
import { CustomAGGrid, type CustomAGGridProps } from '@gridsuite/commons-ui';
import { CustomAGGrid, type CustomAGGridProps, type SxStyle } from '@gridsuite/commons-ui';
import { useDebugRender } from '../../utils/hooks';

type AccessibleAgGridReact<TData> = Omit<
Expand Down Expand Up @@ -50,7 +50,7 @@ const style = {
'@media print': {
pageBreakInside: 'avoid',
},
};
} as const satisfies SxStyle;

// TODO move type generic restoration to commons-ui
// TODO move useDebug feature from env to commons-ui
Expand Down
4 changes: 2 additions & 2 deletions src/pages/common/multi-chip-cell-renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import React, { useRef, useState, useEffect } from 'react';
import { Chip, Grid, Tooltip } from '@mui/material';
import { mergeSx } from '@gridsuite/commons-ui';
import { mergeSx, type MuiStyles } from '@gridsuite/commons-ui';

const maxChipWidth = 100;
const counterChipWidth = 25;
Expand All @@ -23,7 +23,7 @@ const chipStyles = {
fontWeight: 'bold',
},
},
};
} as const satisfies MuiStyles;

export interface MultiChipCellRendererProps {
value: string[];
Expand Down
Loading