Skip to content

Fix Diagrams update at networkVisuParams update #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Diagrams update at networkVisuParams update #3280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 29 additions & 15 deletions src/components/grid-layout/hooks/use-diagram-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,22 +454,25 @@ export const useDiagramModel = ({ diagramTypes, onAddDiagram, onDiagramAlreadyEx

useDiagramParamsInitialization({ onLoadDiagramParams: createDiagram });

const updateAllDiagrams = useCallback(() => {
if (studyUuid === null || currentNode === null || currentRootNetworkUuid === null) {
return null;
}
setDiagramErrors({});
setGlobalError(undefined);
setDiagrams((oldDiagrams) => {
Object.values(oldDiagrams).forEach((diagram) => {
diagram.svg = null; // reset svg
const updateAllDiagrams = useCallback(
(type: DiagramType[] | null = null) => {
if (studyUuid === null || currentNode === null || currentRootNetworkUuid === null) {
return null;
}
setDiagramErrors({});
setGlobalError(undefined);
setDiagrams((oldDiagrams) => {
Object.values(oldDiagrams)
.filter((d) => (type ? type.includes(d.type) : true))
.forEach((diagram) => {
diagram.svg = null; // reset svg
fetchDiagramSvg(diagram);
});
return oldDiagrams;
});
return oldDiagrams;
});
Object.values(diagrams).forEach((diagram) => {
fetchDiagramSvg(diagram);
});
}, [currentNode, currentRootNetworkUuid, diagrams, fetchDiagramSvg, studyUuid]);
},
[currentNode, currentRootNetworkUuid, fetchDiagramSvg, studyUuid]
);

useDiagramEventListener({ createDiagram, removeDiagram });
useDiagramNotificationsListener({ updateAllDiagrams });
Expand Down Expand Up @@ -506,6 +509,17 @@ export const useDiagramModel = ({ diagramTypes, onAddDiagram, onDiagramAlreadyEx
updateAllDiagrams();
}, [currentRootNetworkUuid, updateAllDiagrams]);

useEffect(() => {
// when the network visu params change, update all diagrams
updateAllDiagrams([DiagramType.VOLTAGE_LEVEL, DiagramType.SUBSTATION]);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [
networkVisuParams.singleLineDiagramParameters.diagonalLabel,
networkVisuParams.singleLineDiagramParameters.centerLabel,
networkVisuParams.singleLineDiagramParameters.substationLayout,
networkVisuParams.singleLineDiagramParameters.componentLibrary,
]);

return {
diagrams,
loadingDiagrams,
Expand Down
Loading