-
Notifications
You must be signed in to change notification settings - Fork 4
[WIP] start:dev script with HMR and lint using local librairies #3291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sBouzols
wants to merge
1
commit into
main
Choose a base branch
from
chore_add_npm_start_dev_mode_local_dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -19,12 +19,17 @@ const config = { | |||||
printWidth: 120, | ||||||
singleQuote: true, | ||||||
keySeparator: '=', // format of separator in .properties | ||||||
plugins: ['prettier-plugin-properties'], | ||||||
plugins: ['prettier-plugin-properties', 'prettier-plugin-glsl'], | ||||||
overrides: [ | ||||||
{ | ||||||
files: ['.env', '.env.*'], | ||||||
options: { parser: 'dot-properties' }, | ||||||
}, | ||||||
{ | ||||||
// .frag files are recognized as JavaScript files by default | ||||||
files: ['*.frag'], | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
options: { parser: 'glsl-parser' }, | ||||||
}, | ||||||
{ | ||||||
files: ['.github/**/*'], | ||||||
options: { tabWidth: 2 }, | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/** | ||
* Copyright (c) 2024, RTE (http://www.rte-france.com) | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
*/ | ||
|
||
import { defineConfig, loadEnv, mergeConfig } from 'vite'; | ||
import defaultConfig from './vite.config.ts'; | ||
import react from '@vitejs/plugin-react'; | ||
// @ts-expect-error See https://github.com/gxmari007/vite-plugin-eslint/issues/79 | ||
import eslint from 'vite-plugin-eslint'; | ||
import svgr from 'vite-plugin-svgr'; | ||
import tsconfigPaths from 'vite-tsconfig-paths'; | ||
import * as path from 'node:path'; | ||
|
||
export default defineConfig((configEnv) => { | ||
// Load env file based on `mode` in the current working directory. | ||
// Set the third parameter to '' to load all env regardless of the | ||
// `VITE_` prefix. | ||
const env = loadEnv(configEnv.mode, process.cwd(), ''); | ||
const baseConfig = defaultConfig(configEnv); | ||
baseConfig.plugins = []; // remove existing plugins | ||
return mergeConfig(baseConfig, { | ||
plugins: [ | ||
react(), | ||
eslint({ | ||
failOnWarning: true, | ||
lintOnStart: false, | ||
}), | ||
svgr(), // works on every import with the pattern "**/*.svg?react" | ||
tsconfigPaths(), // to resolve absolute path via tsconfig cf https://stackoverflow.com/a/68250175/5092999 | ||
], | ||
resolve: { | ||
alias: { | ||
// Use source files from the workspace package during demo dev for HMR | ||
'@powsybl/network-map-layers': path.resolve(env.POWSYBL_NETWORK_VIEWER_PATH, 'packages/network-map-layers/src'), | ||
// Also allow importing the library src directly from the demo if needed | ||
'@powsybl/network-viewer': path.resolve(env.POWSYBL_NETWORK_VIEWER_PATH, 'src'), | ||
}, | ||
// Ensure symlinks from the outside dependency don't confuse module resolution | ||
preserveSymlinks: true, | ||
}, | ||
optimizeDeps: { | ||
// Do not prebundle the outside dependency package; we want it treated as source for HMR | ||
exclude: ['@powsybl/network-map-layers', '@powsybl/network-viewer'], | ||
}, | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.