Move GlobalFilter files #3330
Open
Move GlobalFilter files #3330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment on lines
+8
to
+12
| // complete individual global filter | ||
| import type { UUID } from 'crypto'; | ||
|
|
||
| // complete individual global filter | ||
| export interface GlobalFilter { |
There was a problem hiding this comment.
Duplicate comment.
| import { AppState } from '../../redux/reducer'; | ||
|
|
||
| export const useGlobalFilterOptions = () => { | ||
| export function useGlobalFilterOptions() { |
There was a problem hiding this comment.
I prefer this syntax so I am fine with it but is it the "official" syntax of gridsuite ? @etiennehomer ?
There was a problem hiding this comment.
Both are used. It's ok with "function"
| label: countryCode, | ||
| filterType: FilterType.COUNTRY, | ||
| })) | ||
| countryCodes.map((countryCode) => ({ label: countryCode, filterType: FilterType.COUNTRY })) |
There was a problem hiding this comment.
Why do you put all this on a single line ? I think it reduces the readability.
| .then((nominalVoltages) => { | ||
| setVoltageLevelsFilter( | ||
| nominalVoltages.map((nominalV: number) => ({ | ||
| nominalVoltages.map((nominalV) => ({ |
There was a problem hiding this comment.
Why do you reduce the typing ? Is it wrong ?
Comment on lines
+21
to
+24
| /** | ||
| * globals filters are the filters applied to computation results | ||
| * they may contain generic filters | ||
| */ |
There was a problem hiding this comment.
Not very useful anymore. At least not here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
<GlobalFilter/>is now not use only by results tables, moving it under components.Also removing some redundant declaration of variable types.