Add map state persistance #3379
Open
+152
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayoub LABIDI <[email protected]>
klesaulnier
reviewed
Oct 14, 2025
Comment on lines
1032
to
1039
| return { | ||
| zoom: networkMapRef.current?.getCurrentViewState()?.zoom, | ||
| center: [ | ||
| networkMapRef.current?.getCurrentViewState()?.center.lng, | ||
| networkMapRef.current?.getCurrentViewState()?.center.lat, | ||
| ] as [number, number], | ||
| filteredNominalVoltages: filteredNominalVoltages, | ||
| }; |
There was a problem hiding this comment.
call getCurrentViewState() only once
Plus, casting "as [number, number]" here is hiding the problem where "networkMapRef.current?.getCurrentViewState()" is nullish, handle it properly ?
Maybe reset to default positions if no ref is found (should not happen though)
Signed-off-by: Ayoub LABIDI <[email protected]>
Signed-off-by: Ayoub LABIDI <[email protected]>
EstherDarkish
approved these changes
Oct 17, 2025
Signed-off-by: Ayoub LABIDI <[email protected]>
ayolab
force-pushed
the
ayolab/add-map-state-persistance
branch
from
4985fbe to
e154693
Compare
Signed-off-by: Ayoub LABIDI <[email protected]>
ayolab
force-pushed
the
ayolab/add-map-state-persistance
branch
from
ba3a33e to
dac0c41
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.