Refactor useDiagramModel: generate diagramUuid internally when necessary #3409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot let components or clients generate it with v4 depenency refactor(): Add menu utils file to move `getCommonEquipmentType` which is used by menus not diagram cards directly. Signed-off-by: sBouzols <[email protected]>
Signed-off-by: sBouzols <[email protected]>
… conditional type so DiagramParamsWithoutId<DiagramParams> becomes a union of the variants with diagramUuid optional. Remove cast and simplify code Signed-off-by: sBouzols <[email protected]>
Signed-off-by: sBouzols <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useDiagramModelhook should create thediagramUuidinternaly, not let components or clients generate it with v4 dependencyrefactor(): Add menu utils file to move
getCommonEquipmentTypewhich is used by menus not diagram cards directly.